Comment #12 on issue 16008 by [email protected]: Refactor
media::Pipeline to support injected message loops
http://code.google.com/p/chromium/issues/detail?id=16008
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=20412
------------------------------------------------------------------------
r20412 | [email protected] | 2009-07-10 13:47:51 -0700 (Fri, 10 Jul
2009) | 8 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/mock_ffmpeg.cc?r1=20412&r2=20411
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/mock_ffmpeg.h?r1=20412&r2=20411
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/mock_filters.h?r1=20412&r2=20411
D /trunk/src/media/base/mock_media_filters.h
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/pipeline_impl_unittest.cc?r1=20412&r2=20411
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/video_frame_impl_unittest.cc?r1=20412&r2=20411
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/ffmpeg_glue_unittest.cc?r1=20412&r2=20411
D /trunk/src/media/filters/test_video_decoder.h
D /trunk/src/media/filters/test_video_renderer.h
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/media.gyp?r1=20412&r2=20411
Converted remaining tests to use gmock and deleted all old mocking code.
The most important part was refactoring PipelineImpl tests in preparation
for message loop injection. The old mocks just did not work *at all* with
my message loop injection patch.
BUG=16008
TEST=media_unittests should pass and not flake out
Review URL: http://codereview.chromium.org/149423
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
