Status: Available Owner: ---- CC: [email protected], [email protected], [email protected], [email protected] Labels: Type-Other Pri-2 OS-All Area-Infrastructure Size-Large
New issue 16511 by [email protected]: we need a CPP symbol for the GYP buildtype http://code.google.com/p/chromium/issues/detail?id=16511 We have CPP symbols for the two types of branding (GOOGLE_CHROME_BUILD and CHROMIUM_BUILD) from src/build/common.gypi, but the variable 'buildtype' isn't mapped to any cpp symbol, so code checks for the branding instead of the official flag (or both). We should add a symbol for that. In http://crbug.com/149472, I tried using OFFICIAL_BUILD as a cpp symbol, since a bunch of scripts already use it as an environment variable, but there are some other places that also try to define it. My initial attempts to clean it up resulted in pulling on too many connects. We should revisit all the environment variables from the older windows build scripts to get this just a few consistent names. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
