Comment #8 on issue 16068 by [email protected]: Persist bookmark IDs  
across browser restarts
http://code.google.com/p/chromium/issues/detail?id=16068

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=20532

------------------------------------------------------------------------
r20532 | [email protected] | 2009-07-13 14:17:39 -0700 (Mon, 13 Jul 2009)  
| 12 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_codec.cc?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_codec.h?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_model.cc?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_model.h?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_storage.cc?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_storage.h?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_bookmarks_module.h?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_tree_model.cc?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_tree_model.h?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_editor_view.cc?r1=20532&r2=20531
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_editor_view.h?r1=20532&r2=20531

Always persist bookmark IDs.
Remove the preference to persist IDs.
NOTE that we need to save the file the first time with IDs
since existing bookmark files won't have IDs and the file
won't be saved until something changes in the bookmark model.
So we need to explicitly save once when we assign ids for the
first time.

TEST=NONE
BUG=16068

Review URL: http://codereview.chromium.org/149310
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to