Comment #2 on issue 16063 by [email protected]: Popup windows should
not show the bookmarks bar
http://code.google.com/p/chromium/issues/detail?id=16063
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=20773
------------------------------------------------------------------------
r20773 | [email protected] | 2009-07-15 13:00:18 -0700 (Wed, 15 Jul 2009) |
16 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=20773&r2=20772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm?r1=20773&r2=20772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.h?r1=20773&r2=20772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_window_controller.mm?r1=20773&r2=20772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=20773&r2=20772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=20773&r2=20772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=20773&r2=20772
Mac pop-up window happier-ness.
BUG=http://crbug.com/15727, http://crbug.com/16063, http://crbug.com/16329
TEST=A few things.
Bookmark bar test (16063):
- open bookmark bar, then open popup. Popup should not have bmb.
- close bookmark bar, then open popup. Popup should not have bmb.
- In main window, toggle bmb a few times. Popup should not change.
Tab at bottom bug (16329):
- Open 'details' popup in gmail (next to 'last acct activity')
- make sure no tab strip at the bottom of the window
General (15727):
- Open a popup. Make sure no toolbar (back/fwd buttons et al)
Review URL: http://codereview.chromium.org/155444
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---