Comment #2 on issue 16357 by [email protected]: Should not use ID
generator in bookmark codec
http://code.google.com/p/chromium/issues/detail?id=16357
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=20779
------------------------------------------------------------------------
r20779 | [email protected] | 2009-07-15 13:15:26 -0700 (Wed, 15 Jul 2009)
| 10 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_codec.cc?r1=20779&r2=20778
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_codec.h?r1=20779&r2=20778
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc?r1=20779&r2=20778
Don't use ID generation logic always. Only reassign IDs
when checksums differ or if IDs are missing and do that
simply by assigning the next maximum id.
Add a unit test.
BUG=16357
TEST=NONE
Review URL: http://codereview.chromium.org/155560
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
