Comment #11 on issue 16031 by [email protected]: Media filter Initialize() should be void http://code.google.com/p/chromium/issues/detail?id=16031
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=20836
------------------------------------------------------------------------
r20836 | [email protected] | 2009-07-15 18:26:40 -0700 (Wed, 15 Jul
2009) | 10 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/media/buffered_data_source.cc?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/media/buffered_data_source.h?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/filter_host.h?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/filter_host_impl.cc?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/filter_host_impl.h?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/filters.h?r1=20836&r2=20835
A
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/mock_filters.cc
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/mock_filters.h?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/pipeline_impl.cc?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/pipeline_impl.h?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/pipeline_impl_unittest.cc?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/audio_renderer_base.cc?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/audio_renderer_base.h?r1=20836&r2=20835
A
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/audio_renderer_base_unittest.cc
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/decoder_base.h?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/ffmpeg_demuxer.cc?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/ffmpeg_demuxer.h?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/ffmpeg_demuxer_unittest.cc?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/ffmpeg_video_decoder_unittest.cc?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/file_data_source.cc?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/file_data_source.h?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/file_data_source_unittest.cc?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/video_renderer_base.cc?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/video_renderer_base.h?r1=20836&r2=20835
A
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/video_renderer_base_unittest.cc
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/media.gyp?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/media/simple_data_source.cc?r1=20836&r2=20835
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/media/simple_data_source.h?r1=20836&r2=20835
Adding callback support to media filter Initialize() and Seek().
Also includes unit tests for AudioRendererBase and VideoRendererBase.
I had to rollback my first attempt at this change. Original review:
http://codereview.chromium.org/155469
BUG=16014,16031
TEST=media_unittests, layout tests
Review URL: http://codereview.chromium.org/155608
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
