Comment #19 on issue 2780 by [email protected]: RTL: Omnibar -
message "Press Tab to search Google" doesn't show correctly in a "New Tab"
for RTL locales
http://code.google.com/p/chromium/issues/detail?id=2780
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=21312
------------------------------------------------------------------------
r21312 | [email protected] | 2009-07-22 13:07:47 -0700 (Wed, 22 Jul 2009) |
12 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.cc?r1=21312&r2=21311
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.h?r1=21312&r2=21311
This CL fixes issue 2780 -- RTL: Omnibar - message "Press Tab to search
Google" doesn't show correctly in a "New Tab" for RTL locales
Because of the bug in PosFromChar() (see bug report for detailed
information), we actually calculate the width of the string ourselves using
font.GetStringWidth().
BUG=http://crbug.com/2780
TEST=
1 Start Chrome with a *new user data directory* and make sure the UI
language is Hebrew.
2 Type www.google.com in the omnibox and press Enter.
3 Close and re-open the browser.
4 Type character "h" in Ominibox
5 Message "Press Tab to search Google" should show correctly, not
only "Tab" is displayed
Review URL: http://codereview.chromium.org/155789
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
