[chromium-bugs] Issue 17593 in chromium: When no NTP background image is provided, the notused.png image paints as white.

[codesite-noreply]

Comment #1 on issue 17593 by bugdro...@chromium.org: When no NTP background  
image is provided, the notused.png image paints as white.
http://code.google.com/p/chromium/issues/detail?id=17593

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=21509

------------------------------------------------------------------------
r21509 | g...@chromium.org | 2009-07-23 21:25:13 -0700 (Thu, 23 Jul 2009) |  
15 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/chromium/product_logo.png?r1=21509&r2=21508
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/chromium/product_logo_white.png
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_close.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_close_h.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_close_p.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_list_off.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_list_off_h.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_list_off_p.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_list_on.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_list_on_h.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_list_on_p.png?r1=21509&r2=21508
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_menu_mask.png
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_option.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_option_h.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_option_p.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_pin_off.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_pin_off_h.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_pin_off_p.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_pin_on.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_pin_on_h.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_pin_on_p.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_thumb_off.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_thumb_off_h.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_thumb_off_p.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_thumb_on.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_thumb_on_h.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ntp_thumb_on_p.png?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_provider.cc?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_provider.h?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/new_new_tab.css?r1=21509&r2=21508
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/new_tab_theme.css?r1=21509&r2=21508

Fix a bunch of bugs related to NNTP theming.

Basically:
- Add NNTP Theming

BrowserThemeProvider:
- Add NNTP logo inversion capability
- Only allow a set of images to be themed.
- Tint incognito windows correctly.
(Sorry for the feature-mush)

BUG=17379,14578,17593
TEST=Make sure the NNTP is themed correctly.

Review URL: http://codereview.chromium.org/159305
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---