Comment #7 on issue 17107 by [email protected]: Clean up PipelineImpl,
PipelineThread and FilterHostImpl mess
http://code.google.com/p/chromium/issues/detail?id=17107
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=21735
------------------------------------------------------------------------
r21735 | [email protected] | 2009-07-27 16:04:46 -0700 (Mon, 27 Jul
2009) | 16 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/195/src/media/base/pipeline_impl.cc?r1=21735&r2=21734
M
http://src.chromium.org/viewvc/chrome/branches/195/src/media/base/pipeline_impl.h?r1=21735&r2=21734
M
http://src.chromium.org/viewvc/chrome/branches/195/src/media/base/pipeline_impl_unittest.cc?r1=21735&r2=21734
Merge 21464 - Merged PipelineInternal into PipelineImpl, eliminating a ton
of threadUNsafeness and confusion.
Long story short: there's no reason to split an implementation of class
between two classes. The data was being held in one class, with the other
class accessing it privately without acquiring the lock. Really, really
painful to debug as well.
Now we have a unified implementation of Pipeline that takes care of client
API requests as well as filter interaction.
Since Pipeline is properly reference counted and there are two less objects
to worry about, the crash reported in 3.0.195.1 should also be resolved.
BUG=17107,17548
TEST=pipeline tests, media player and chrome ui tests
Review URL: http://codereview.chromium.org/159246
[email protected]
Review URL: http://codereview.chromium.org/160213
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
