Comment #8 on issue 15079 by [email protected]: NNTP: First run
experience
http://code.google.com/p/chromium/issues/detail?id=15079
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=21737
------------------------------------------------------------------------
r21737 | [email protected] | 2009-07-27 16:08:20 -0700 (Mon, 27 Jul
2009) | 15 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/app/generated_resources.grd?r1=21737&r2=21736
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/dom_ui/new_tab_ui.cc?r1=21737&r2=21736
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/resources/new_new_tab.css?r1=21737&r2=21736
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/resources/new_new_tab.js?r1=21737&r2=21736
Merge 21480 - Adds the first run banner.
First run is determined by checking if there are no thumbnails. The check
for no thumbnails is done on the backend since I need to add code to add
some pre populated thumbnails and therefore the most visited pages will not
be empty on the client. There is one edge case where the banner can show up
again and that is if the user blacklists all his thumbnails and restarts
chrome.
Also, updates the look of the fillers to match the latest mocks.
BUG=15079
TEST=Start with a new empty profile. You should see the blue first run
banner. Then navigate to some link and come back the NTP. The banner should
not be shown again. Also, test that this did not break the yellow
notification banner shown when a thumbnail is removed.
Review URL: http://codereview.chromium.org/159304
[email protected]
Review URL: http://codereview.chromium.org/160214
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
