Comment #9 on issue 15648 by [email protected]: Move ResourceFetcher
and related usage out of WebFrame
http://code.google.com/p/chromium/issues/detail?id=15648
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=22253
------------------------------------------------------------------------
r22253 | [email protected] | 2009-08-02 12:23:45 -0700 (Sun, 02 Aug 2009)
| 31 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/errorpage_uitest.cc?r1=22253&r2=22252
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/navigation_state.h?r1=22253&r2=22252
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=22253&r2=22252
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.h?r1=22253&r2=22252
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/iframe_dns_error.html
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/title3.html
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/alt_error_page_resource_fetcher.cc?r1=22253&r2=22252
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/alt_error_page_resource_fetcher.h?r1=22253&r2=22252
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframe.h?r1=22253&r2=22252
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframe_impl.cc?r1=22253&r2=22252
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframe_impl.h?r1=22253&r2=22252
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframeloaderclient_impl.cc?r1=22253&r2=22252
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframeloaderclient_impl.h?r1=22253&r2=22252
Move alternate error page loading out of WebFrame.
Make the RenderView be in charge of loading alternate error pages.
While working on this change, I noticed several related bugs:
1- Loading an URL with an invalid host name from the new tab page results
in
an error page. If you hit back and then forward, you will be left with an
empty location bar. In a debug build this trips an assertion in
ClassifyNavigation because the given page_id is -1. This problem is caused
by
not duplicating the NavigationState of the failed load when creating a load
for
the error page. Hence, the pending_page_id of the forward navigation is
lost.
2- Loading an URL with an invalid host name as a subframe results in an
extra
navigation in session history. One navigation for the main frame and one
navigation for the error page load. This is another symptom of the problem
described in #1. However, the solution is different. Here, we need to know
that the subframe load is an AUTO_SUBFRAME load so that we load the error
page
using 'replace' semantics (so that WebCore does not generate a new session
history entry).
Finally, I decided to restrict alternative DNS error pages to only work for
the
main frame to match what we do for alternative 404 error pages. It doesn't
seem
worth it to show link doctor results for subframes since their primary
purpose
is to assist people who mis-type an URL.
R=tony,brettw
BUG=15648
TEST=covered by errorpage_uitest.cc
Review URL: http://codereview.chromium.org/159575
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
