Comment #26 on issue 11981 by [email protected]: Deadkeys do not work
http://code.google.com/p/chromium/issues/detail?id=11981

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=22262

------------------------------------------------------------------------
r22262 | [email protected] | 2009-08-03 00:38:06 -0700 (Mon, 03 Aug 2009)  
| 13 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h?r1=22262&r2=22261
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm?r1=22262&r2=22261
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/native_web_keyboard_event.h?r1=22262&r2=22261
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/native_web_keyboard_event_mac.mm?r1=22262&r2=22261
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebInputEvent.h?r1=22262&r2=22261
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/mac/WebInputEventFactory.h?r1=22262&r2=22261
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/mac/WebInputEventFactory.mm?r1=22262&r2=22261

Implement the NSTextInput protocol.

This change implements the NSTextInput protocol to integrate dead-keys and  
IME support into Mac Chromium.
Same as Linux, to improve compatibility with Windows Chrome, this change  
emulates IPC messages sent on Windows when we input characters to fix Issue  
11952 and Issue 11981.
Even though I notice we need more work for fixing edge cases (e.g.  
disabling IMEs on a password input) also on Mac, it is the good starting  
point. (Supporting edge-cases requires complicated code and it makes hard  
to review.)

BUG=11952 "IME support is not implemented"
BUG=11981 "Deadkeys do not work"
BUG=16393 "Mac: Not able to insert any letter using "Special Characters"  
pallet"
TEST=Open a web page which contains an <input> form (e.g.  
<http://www.google.com/>), type a '[{' key and an 'A' key on a  
Canadian-French keyboard, and see a Latin character "U+00E2" is displayed  
in the <input> form.
TEST=Open a web page which contains an <input> form (e.g.  
<http://www.google.com/>), enable an Chinese Pinyin IME, type a 'W' key,  
type an 'O' key, and see a Chinese character is displayed in the <input>  
form.
TEST=Open a web page which contains a <textarea> form, type a return key,  
and see a new line is inserted.
Review URL: http://codereview.chromium.org/150206
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to