Comment #10 on issue 14323 by [email protected]: [www.appleby.ie]: Page not refreshed when new page selected http://code.google.com/p/chromium/issues/detail?id=14323
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=22369
------------------------------------------------------------------------
r22369 | [email protected] | 2009-08-04 00:06:39 -0700 (Tue, 04 Aug 2009)
| 23 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/plugin_messages_internal.h?r1=22369&r2=22368
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/webplugin_delegate_stub.cc?r1=22369&r2=22368
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/webplugin_delegate_stub.h?r1=22369&r2=22368
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/webplugin_proxy.cc?r1=22369&r2=22368
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/webplugin_proxy.h?r1=22369&r2=22368
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/webplugin_delegate_proxy.cc?r1=22369&r2=22368
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/webplugin_delegate_proxy.h?r1=22369&r2=22368
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/plugin_instance.cc?r1=22369&r2=22368
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/plugin_stream_url.cc?r1=22369&r2=22368
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/plugin_stream_url.h?r1=22369&r2=22368
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/test/plugin_get_javascript_url_test.cc?r1=22369&r2=22368
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/test/plugin_get_javascript_url_test.h?r1=22369&r2=22368
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webplugin.h?r1=22369&r2=22368
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webplugin_impl.cc?r1=22369&r2=22368
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webplugin_impl.h?r1=22369&r2=22368
Another attempt at landing this patch.
The reliability tests regressions caused by this patch have been addressed
by the upstream bug fix https://bugs.webkit.org/show_bug.cgi?id=27769
The IPCs for carrying data requested by plugins have been changed from
synchronous IPCs to asynchronous IPCs.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=14323,
where the Flash plugin would not render content on the page if these IPCs
were processed while the plugin waited for sync calls like NPN_Evaluate to
return.
This CL also fixes the following bugs, which were crashes in reliability
test runs when this patch was landed last time.
http://code.google.com/p/chromium/issues/detail?id=18058
http://code.google.com/p/chromium/issues/detail?id=18059
The crash happens because of NPP_Write calls issued to the plugin while it
is waiting for an NPN_Invoke call to return in the context of
NPP_NewStream. Inspecting the safari plugin implementation revealed that
they defer the resource load before calling the plugin and restore it on
return.
We emulate this behavior via an IPC sent from the plugin which serves as an
acknowledgement.
Test=covered by UI tests.
Bug=14323,18058,18059
Review URL: http://codereview.chromium.org/159746
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
