Comment #14 on issue 16249 by [email protected]: Thumbnails do not
move while dragging on the new new tab page
http://code.google.com/p/chromium/issues/detail?id=16249
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=22542
------------------------------------------------------------------------
r22542 | [email protected] | 2009-08-05 14:49:26 -0700 (Wed, 05 Aug 2009)
| 18 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_main.cc?r1=22542&r2=22541
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc?r1=22542&r2=22541
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h?r1=22542&r2=22541
GTK: Fancy html5 draggy stuff.
Also, don't crash in release mode when the tab contents is deleted during a
drag.
1) Source side: when the tab contents is going down, abort the current drag
(if any). Initiate drags on a GtkInvisible (matching firefox, among other
programs I assume). This lets us give up ownership of the drag widget and
let the drag unwind.
2) Destination side: make a seemingly harmless GTK assert point to a crbug
bug. This warrants further investigation.
BUG=16249
TEST=drag around ntp thumbnails
BUG=18557
In release mode, you should be able to do all the following without
crashing or getting any asserts besides the two mentioned in 18557
TEST=drag something from gedit over a tab that closes
TEST=drag something from the render view over a tab that closes
TEST=drag something from the render view off of the browser from within a
tab that closes
TEST=repeat all the above with a tab that is being swapped out according to
the repro steps in bug 16073
Review URL: http://codereview.chromium.org/159889
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
