Comment #7 on issue 17619 by [email protected]: Fix the  
resize-sibling-of-parent nastiness with bookmark and info bar resizing
http://code.google.com/p/chromium/issues/detail?id=17619

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=22721

------------------------------------------------------------------------
r22721 | [email protected] | 2009-08-06 21:49:14 -0700 (Thu, 06 Aug  
2009) | 17 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/InfoBarContainer.xib?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.h?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/download_shelf_controller.h?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/download_shelf_controller.mm?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/download_shelf_mac.mm?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/download_shelf_mac_unittest.mm?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_container_controller.h?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_container_controller.mm?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_container_controller_unittest.mm?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=22721&r2=22720
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=22721&r2=22720
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/view_resizer.h
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/view_resizer_pong.h
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/view_resizer_pong.mm
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=22721&r2=22720

Reverts the revert of 22517.

Rewrites the Mac view resizing logic to have the BrowserWindowController
directly resize and relayout its children views.  Now when a view needs
to be resized, it asks its resize delegate (typically its controller's
parent) to perform the resize.

BUG=http://crbug.com/17619

TEST=Make sure that views are laid out correctly, even when they change  
size.
Open and close the bookmark bar.  Trigger an infobar and then close it.   
Trigger
the download shelf and then close it.  Trigger a download shelf with the  
infobar
open, or with the bookmark bar open.  Switch to and from fullscreen with  
various
bars open.  Resize the browser window with various bars open.  Start the  
browser
with and without the bookmark bar open.  Try all of the above in a popup  
window.

Review URL: http://codereview.chromium.org/165014
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to