Comment #8 on issue 17985 by [email protected]: Crash -
net::ClientSocketPoolBase::CleanupIdleSockets(bool)
http://code.google.com/p/chromium/issues/detail?id=17985
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=22811
------------------------------------------------------------------------
r22811 | [email protected] | 2009-08-07 15:40:01 -0700 (Fri, 07 Aug
2009) | 16 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/195/src/net/socket/client_socket_pool_base.cc?r1=22811&r2=22810
M
http://src.chromium.org/viewvc/chrome/branches/195/src/net/socket/client_socket_pool_base.h?r1=22811&r2=22810
M
http://src.chromium.org/viewvc/chrome/branches/195/src/net/socket/client_socket_pool_base_unittest.cc?r1=22811&r2=22810
Merge 21988 - Fix crash in client_socket_pool_base.cc.
The CHECK that was being hit showed a real problem: group's IsEmpty
should take into account the pending requests queue too.
I also made IsEmpty check for connecting requests queue emptiness,
so we can be sure that IsEmpty really means empty.
TEST=Added a regression test
ClientSocketPoolBaseTest.GroupWithPendingRequestsIsNotEmpty to
net_unittests.
http://crbug.com/17985
Review URL: http://codereview.chromium.org/159597
[email protected]
Review URL: http://codereview.chromium.org/164200
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
