Comment #10 on issue 12835 by [email protected]: DCHECK in
SafeBrowsingService::UpdateStarted update_in_progress_
http://code.google.com/p/chromium/issues/detail?id=12835
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=22814
------------------------------------------------------------------------
r22814 | [email protected] | 2009-08-07 15:47:56 -0700 (Fri, 07 Aug 2009) |
17 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/protocol_manager.cc?r1=22814&r2=22813
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/protocol_manager.h?r1=22814&r2=22813
Fix for an "update in progress" DCHECK.
A DCHECK in SafeBrowsingService::UpdateStarted can potentially be
triggered if there is an error opening the database for reading,
or if there is no response from the server for a update request.
Both of these cases can cause our 'update_in_progress_' flag to
not be reset properly before the next update.
This CL adds:
- a timeout for update responses
- better handling for database errors
that properly resets the update state.
BUG=12835 (http://crbug.com/12835)
TEST=None.
Review URL: http://codereview.chromium.org/165008
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
