Comment #5 on issue 17862 by [email protected]: Browser crash with
bookmark bar context menu
http://code.google.com/p/chromium/issues/detail?id=17862
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=22842
------------------------------------------------------------------------
r22842 | [email protected] | 2009-08-07 17:49:08 -0700 (Fri, 07 Aug
2009) | 15 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/views/bookmark_bar_view_test.cc?r1=22842&r2=22841
M
http://src.chromium.org/viewvc/chrome/branches/195/src/views/controls/menu/chrome_menu.cc?r1=22842&r2=22841
M
http://src.chromium.org/viewvc/chrome/branches/195/src/views/controls/menu/chrome_menu.h?r1=22842&r2=22841
Merge 22180 - Fixes possible crash in bookmark menus. Specifically if you
had a menu
showing and brought up the context menu and clicked a separator we
would do the wrong thing. We would try to show the first menu again,
without cancelling out of the inner loop, which would most likely
result in a crash. The right thing to do in this case is not close the
context menu (this behavior can be seen in windows as well).
BUG=17862
TEST=see bug, but also covered by ui test now.
Review URL: http://codereview.chromium.org/160458
[email protected]
Review URL: http://codereview.chromium.org/164217
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
