Comment #9 on issue 12701 by [email protected]: Ability to set a new icon for an experimental group http://code.google.com/p/chromium/issues/detail?id=12701
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=23179
------------------------------------------------------------------------
r23179 | [email protected] | 2009-08-12 00:19:22 -0700 (Wed, 12 Aug 2009) |
14 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/browser_main.cc?r1=23179&r2=23178
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/first_run.h?r1=23179&r2=23178
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/first_run_win.cc?r1=23179&r2=23178
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/common/temp_scaffolding_stubs.cc?r1=23179&r2=23178
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/setup/install.cc?r1=23179&r2=23178
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/setup/install.h?r1=23179&r2=23178
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/setup/setup_main.cc?r1=23179&r2=23178
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/util/browser_distribution.cc?r1=23179&r2=23178
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/util/browser_distribution.h?r1=23179&r2=23178
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/util/google_chrome_distribution.cc?r1=23179&r2=23178
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/util/google_chrome_distribution.h?r1=23179&r2=23178
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/util/google_chrome_distribution_unittest.cc?r1=23179&r2=23178
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/util/master_preferences.cc?r1=23179&r2=23178
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/util/master_preferences.h?r1=23179&r2=23178
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/util/util_constants.h?r1=23179&r2=23178
Merge 22284 - Refactoring of master preferences parsing before adding a new
preference.
Currently we are parsing master preferences file three time on startup.
Since we only return an int bit mask flag after parsing preferences, it can
not handle any preference other than boolean and we end up reading it again
for first run tabs and ping delay. This change refactors all the
preferences parsing logic to directly pass around DictionaryValue object
around in Chrome as well as installer.
No functional change but this will make adding a new preference for new
icon more logical since we will not read the preferences file once again.
BUG=12701
TEST=Make sure all the distribution preferences still work as before.
Review URL: http://codereview.chromium.org/159539
[email protected]
Review URL: http://codereview.chromium.org/165382
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
