Comment #3 on issue 18980 by [email protected]: Crash in
CGContextSaveGState in Flash plugin process
http://code.google.com/p/chromium/issues/detail?id=18980
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=23322
------------------------------------------------------------------------
r23322 | [email protected] | 2009-08-13 10:56:55 -0700 (Thu, 13 Aug
2009) | 8 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/webplugin_proxy.cc?r1=23322&r2=23321
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h?r1=23322&r2=23321
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm?r1=23322&r2=23321
Add an UpdateContext call to WebPluginDelegateImpl on the Mac.
On the Mac, Flash appears to cache the CGContextRef provided in
NPP_SetWindow until the next NPP_SetWindow call, so we need to call it
sometime before the next plugin paint. This allows us to call NPP_SetWindow
before telling the plugin to paint, but not from the Paint function itself
(where it could have bad side-effects).
BUG=18894,18980
TEST=Switch to HQ on a YouTube video; Flash should not crash.
Review URL: http://codereview.chromium.org/165344
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
