Comment #6 on issue 19002 by [email protected]: Re-enable  
http_bridge_unittest.cc and sync_setup_wizard_unittest.cc ASAP.
http://code.google.com/p/chromium/issues/detail?id=19002

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=23414

------------------------------------------------------------------------
r23414 | [email protected] | 2009-08-13 20:24:23 -0700 (Thu, 13 Aug 2009) |  
9 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc?r1=23414&r2=23413
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/test_browser_window.h?r1=23414&r2=23413

Fix SyncSetupWizard test again; the order of operations when the  
HtmlDialogView
infrastructure closes a dialog is a bit different from what I was  
simulating in this
test.  It goes 1) obtain handlers from delegate. 2) delete delegate. 3)  
delete handlers.
Also add a virtual dtor to TestBrowserWindow.

BUG=19002
TEST=SyncSetupWizardTest

Review URL: http://codereview.chromium.org/164494
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to