Comment #1 on issue 15289 by [email protected]: Sharing model of {cookie_store_ and proxy_service_} in ChromeURLRequestContext is wrong http://code.google.com/p/chromium/issues/detail?id=15289
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=23612
------------------------------------------------------------------------
r23612 | [email protected] | 2009-08-17 20:58:09 -0700 (Mon, 17 Aug 2009)
| 10 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/chrome_url_request_context.cc?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/resolve_proxy_msg_helper.h?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_layer.cc?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_layer.h?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_layer_unittest.cc?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_session.h?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_transaction_unittest.cc?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_script_fetcher_unittest.cc?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_service.cc?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_service.h?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_service_unittest.cc?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/fetch/fetch_client.cc?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_context.h?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_unittest.cc?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_unittest.h?r1=23612&r2=23611
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell_request_context.cc?r1=23612&r2=23611
Reference count ProxyService.
This is necessary since ProxyService is getting shared between chrome's url
request contexts (off the record, media), and the current way it is being
shared could result in free memory read/writes during shutdown.
This is a step towards fixing http://crbug.com/15289.
BUG=http://crbug.com/15289
TEST=The existing tests should continue to pass following this refactor.
Review URL: http://codereview.chromium.org/165430
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
