Comment #6 on issue 19544 by [email protected]: Fix test_shell
regressions jorlow introduced
http://code.google.com/p/chromium/issues/detail?id=19544
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=23684
------------------------------------------------------------------------
r23684 | [email protected] | 2009-08-18 19:13:14 -0700 (Tue, 18 Aug 2009)
| 13 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=23684&r2=23683
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/layout_test_controller.cc?r1=23684&r2=23683
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_webview_delegate.cc?r1=23684&r2=23683
The 2 layout test regressions happened due to changes in the test shell.
After looking at the diff, I realized that I had changed the behavior more
than necessary. So I've reverted back the parts that were using the web
settings API directly and now they're setting properties on their web
preferences object and then just applying that to the web view. This should
match the behavior of before.
This is fixing some behavior committed in
http://src.chromium.org/viewvc/chrome?view=rev&revision=23589
TEST=none
BUG=19544
Review URL: http://codereview.chromium.org/171097
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
