Comment #12 on issue 17301 by [email protected]: Bookmark toolbar: Apple-Click (or similar) should open in new tab http://code.google.com/p/chromium/issues/detail?id=17301
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=23693
------------------------------------------------------------------------
r23693 | [email protected] | 2009-08-18 20:52:11 -0700 (Tue, 18 Aug 2009) |
29 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm?r1=23693&r2=23692
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm?r1=23693&r2=23692
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.cc?r1=23693&r2=23692
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.h?r1=23693&r2=23692
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=23693&r2=23692
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm?r1=23693&r2=23692
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm?r1=23693&r2=23692
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=23693&r2=23692
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/event_utils.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/event_utils.mm
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/event_utils_unittest.mm
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller.mm?r1=23693&r2=23692
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_controller.mm?r1=23693&r2=23692
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm?r1=23693&r2=23692
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/test_event_utils.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/test_event_utils.mm
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=23693&r2=23692
D /trunk/src/chrome/common/cocoa_utils.h
D /trunk/src/chrome/common/cocoa_utils.mm
D /trunk/src/chrome/common/cocoa_utils_unittest.mm
This changelist represents the necessary merger of two others:
http://codereview.chromium.org/172082
Create new event_utils.h file for Cocoa-specific event to
WindowOpenDisposition
cracking.
Hook this up to BookmarkBarController so that clicks to bookmark items use
the
oracle function to determine where the bookmark should be opened.
BUG=17301
TEST=Cmd+Click etc on bookmark items should work. See bug and unit test
attached.
http://codereview.chromium.org/174021
Convert users of the "get last active browser, get selected tab contents,
open
url" pattern to just call OpenURL on Browser directly.
Makes GetOrCreateTabbedBrowser public on Browser, and makes it static so it
can
be called with a provided profile.
BUG=none
TEST=Try opening links from the bookmark/history menus on mac, with and
without
an existing window open, with an active incognito window, etc. The links
should
all open in the last active non-incognito window, or create a new
non-incognito
window if none is open.
Review URL: http://codereview.chromium.org/173044
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
