Comment #7 on issue 14929 by [email protected]: Need bookmark bubble http://code.google.com/p/chromium/issues/detail?id=14929
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=23886
------------------------------------------------------------------------
r23886 | [email protected] | 2009-08-20 14:24:29 -0700 (Thu, 20 Aug 2009) |
16 lines
Changed paths:
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/BookmarkBubble.xib
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=23886&r2=23885
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bubble_view.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bubble_view.mm
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bubble_view_unittest.mm
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bubble_window.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bubble_window.mm
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bubble_window_unittest.mm
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h?r1=23886&r2=23885
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm?r1=23886&r2=23885
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.h?r1=23886&r2=23885
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm?r1=23886&r2=23885
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm?r1=23886&r2=23885
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.h?r1=23886&r2=23885
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=23886&r2=23885
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm?r1=23886&r2=23885
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=23886&r2=23885
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=23886&r2=23885
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=23886&r2=23885
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=23886&r2=23885
Bookmark STAR bubble.
BUG=http://crbug.com/14929
Sample image attached to bug.
TEST=Click the STAR to add a bookmark.
Watch bubble come up. Title is "Bookmark added!"
Confirm fields are OK.
Switch tabs and see bubble go away.
Click STAR again.
Watch bubble come up. Title is "Bookmark"
Make sure all the buttons work (Edit, Close, Remove).
Make sure you can change the title and parent folder.
Make sure "Choose another folder..." opens edit window.
Review URL: http://codereview.chromium.org/171016
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
