Comment #39 on issue 14756 by [email protected]: update hunspell to
the latest stable version to use the latest dictionary format
http://code.google.com/p/chromium/issues/detail?id=14756
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=24590
------------------------------------------------------------------------
r24590 | [email protected] | 2009-08-26 21:42:03 -0700 (Wed, 26 Aug 2009)
| 7 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/hunspell128/src/hunspell/affixmgr.cxx?r1=24590&r2=24589
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/hunspell128/src/hunspell/affixmgr.hxx?r1=24590&r2=24589
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/hunspell128/src/hunspell/filemgr.cxx?r1=24590&r2=24589
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/hunspell128/src/hunspell/filemgr.hxx?r1=24590&r2=24589
The first step towards fixing valgrind errors in the new hunspell.
This change fixes valgrind errors occured when
running 'SpellCheckTest.SpellCheckStrings_EN_US'
and 'SpellCheckTest.SpellCheckText'.
It seems the original code forgots deleting a temporary buffer created
in 'line = new char[]'. To avoid creating a temporary buffer, this change
implements our own FileMgr class that encapsulates operations for reading a
BDICT file, and put some of our hacks in the class.
BUG=14756
TEST=chrome_test.sh -t unit
--gtest_filter='SpellCheckTest.SpellCheckStrings_EN_US'
Review URL: http://codereview.chromium.org/173468
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
