Comment #6 on issue 20297 by [email protected]: Typing backspace while  
in a form field causes the browser to go back in its history
http://code.google.com/p/chromium/issues/detail?id=20297

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=24719

------------------------------------------------------------------------
r24719 | [email protected] | 2009-08-27 20:48:01 -0700 (Thu, 27 Aug 2009)  
| 8 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc?r1=24719&r2=24718

Fix issue 20297: Typing backspace while in a form field causes the browser  
to go back in its history

With the changes made in CL http://codereview.chromium.org/173344,  
gtk_window_activate_key() is used to handle a key event that was not  
handled by webkit. Unlike the old code, gtk_window_activate_key() may match  
the key event with predefined accelerators according to its  
hardware_keycode rather than keyval. Thus, we need to set hardare_keycode  
to an invalid value in GtkIMContextWrapper if the key event is handled by  
IME, to prevent BrowserWindowGtk from handling it again.

BUG=20297: Typing backspace while in a form field causes the browser to go  
back in its history
TEST=Starts scim's XIM server by running "scim -d", then runs chrome with  
GTK_IM_MODULE=xim. Open www.google.com and press backspace in the search  
box, the browser shall not go back to previous page.

Review URL: http://codereview.chromium.org/179016
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to