Updates:
        Cc: [email protected]

Comment #1 on issue 20673 by [email protected]: DCHECK failed:  
(BackingStoreManager::MemorySize() + new_mem) < max_mem.
http://code.google.com/p/chromium/issues/detail?id=20673

I've looked at this issue with gdb. It looks like the DCHECK failure occurs  
when current_mem + new_mem == max_mem (e.g., 30720000, 15360000, and  
46080000 respectively).

   [src/chrome/browser/renderer_host/backing_store_manager.cc]
   size_t new_mem = backing_store_size.GetArea() * 4;
   size_t current_mem = BackingStoreManager::MemorySize();
   size_t max_mem = MaxBackingStoreMemory();
   DCHECK(new_mem < max_mem);
   if (current_mem + new_mem > max_mem) {
     // ...
     CreateCacheSpace((current_mem + new_mem) - max_mem);
   }
   DCHECK((BackingStoreManager::MemorySize() + new_mem) < max_mem);

I believe the DCHECK should be:

   DCHECK((BackingStoreManager::MemorySize() + new_mem) <= max_mem);

I've created a tiny patch.
http://codereview.chromium.org/176037


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to