Comment #10 on issue 20690 by [email protected]: bad plug-in install
experience
http://code.google.com/p/chromium/issues/detail?id=20690
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=24995
------------------------------------------------------------------------
r24995 | [email protected] | 2009-08-31 17:43:21 -0700 (Mon, 31 Aug 2009) |
9 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/WebKit.cpp?r1=24995&r2=24994
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/default_plugin/install_dialog.cc?r1=24995&r2=24994
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/default_plugin/install_dialog.h?r1=24995&r2=24994
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/default_plugin/plugin_impl_win.cc?r1=24995&r2=24994
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/default_plugin/plugin_impl_win.h?r1=24995&r2=24994
Fix two issues with the plugin installer.
The first is that we weren't reloading the pages with plugins.
The second is that there was a InstallerDialog instance per plugin object
on the page. On a page like nytimes.com that creates and destroys a Flash
object on loading, this meant that if the user clicked on the
plugin/infobar inbetween, the dialog would show up and then get hidden
abruptly.
TEST=go to nytimes.com on a machine without Flash installed and click the
infobar as soon as it shows up.
BUG=20690
Review URL: http://codereview.chromium.org/179051
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
