Comment #15 on issue 20045 by [email protected]: crash in  
WebPluginDelegateImpl::Initialize with flash -- gcc 4.4 bug?
http://code.google.com/p/chromium/issues/detail?id=20045

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=25003

------------------------------------------------------------------------
r25003 | [email protected] | 2009-08-31 18:07:35 -0700 (Mon, 31 Aug  
2009) | 5 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc?r1=25003&r2=25002

Linux gcc4.4 fix: stop crashing when loading flash.
sizeof(bool) is 1 byte in opt mode.  We pass a pointer to a bool to a  
function expecting a void*.  It writes 4 bytes of data to the pointer,  
rather than 1 byte.  This corrupts the stack bordering the bool stack  
variable, thereby manifesting itself as a crash.  In particular, we were  
overwriting a spilled register (which stored an object pointer) with 3  
bytes worth of zeros.  After returning from the function, we called into  
the object, which now had the wrong pointer.
BUG=http://crbug.com/20045

Review URL: http://codereview.chromium.org/178046
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to