Comment #8 on issue 17720 by [email protected]: Still can't close a
bunch of tabs quickly by mashing the mouse button
http://code.google.com/p/chromium/issues/detail?id=17720
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=25029
------------------------------------------------------------------------
r25029 | [email protected] | 2009-09-01 06:40:24 -0700 (Tue, 01 Sep
2009) | 15 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_controller.h?r1=25029&r2=25028
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_controller.mm?r1=25029&r2=25028
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_strip_controller.h?r1=25029&r2=25028
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_strip_controller.mm?r1=25029&r2=25028
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_view.mm?r1=25029&r2=25028
(Mac) Make mashing the close tab button work.
To do this, I had to commit several crimes against humanity. In
particular, Cocoa doesn't generate the required extra hit tests during
animations, so we have to. Sometimes, it gets really messed up and ends
up hitting the "drag blocking view". Moreover, we have to account for
the possibility of the mouse down hitting a moving tab, and going up on
the close button, etc.
BUG=17720
TEST=Mash the close tabs button under a wide variety of situations. \
Also make sure that the handling of the tabs (dragging, etc.) \
hasn't accidentally been messed up.
Review URL: http://codereview.chromium.org/174461
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
