Comment #37 on issue 15261 by [email protected]: Crash in  
history::TextDatabase::GetTextMatches
http://code.google.com/p/chromium/issues/detail?id=15261

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=25141

------------------------------------------------------------------------
r25141 | [email protected] | 2009-09-01 18:46:36 -0700 (Tue, 01 Sep 2009)  
| 12 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/README.chromium?r1=25141&r2=25140
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/ext/fts1/fts1.c?r1=25141&r2=25140
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/ext/fts1/fts1_tokenizer1.c?r1=25141&r2=25140
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/ext/fts1/simple_tokenizer.c?r1=25141&r2=25140
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/ext/fts2/fts2.c?r1=25141&r2=25140
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/ext/fts2/fts2_tokenizer1.c?r1=25141&r2=25140
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/ext/fts3/fts3.c?r1=25141&r2=25140
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/ext/fts3/fts3_tokenizer1.c?r1=25141&r2=25140
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/safe-tolower.patch

Fix issue 15261: Crash in history::TextDatabase::GetTextMatches

The crash in history::TextDatabase::GetTextMatches is caused by unexpected  
result of tolower() in some locales such as tr_TR.UTF-8. This CL fixes this  
issue by using following statement to replace tolower():

(ch>='A' && ch<='Z') ? (ch-'A'+'a') : ch

which will always return expected result for ascii characters regardless of  
current locale.

BUG=15261 Crash in history::TextDatabase::GetTextMatches
TEST=none

Review URL: http://codereview.chromium.org/174387
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to