Updates:
        Status: Available

Comment #5 on issue 20594 by [email protected]: Additional Cache Control  
Headers in 304 request are ignored
http://code.google.com/p/chromium/issues/detail?id=20594

> I don't think that we are having issues merging the headers together. It  
> looks like the
> problem is that the request an response time are not being updated.

Yes, confirmed.

The merging of the headers works just fine -- the "Date" and "Expiration"  
headers get updated and written back to the cache properly.

The issue is that we don't actually use the merged "Date" header to  
determine if validation is required. Instead we use
|response_.response_time|  which has NOT been updated.

So I reckon the fix is simply to add this line after updating the headers:

   response_.headers->Update(*new_response->headers);
   response_.response_time = new_response.response_time;  <---- ADDED

> Could it be a regression?

Looks like the problem has been here for a while.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to