Comment #3 on issue 20813 by [email protected]: Bookmark bar
offTheSideButton_ does not respond to -setMouseInside:animate:
http://code.google.com/p/chromium/issues/detail?id=20813
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=25507
------------------------------------------------------------------------
r25507 | [email protected] | 2009-09-04 13:43:14 -0700 (Fri, 04 Sep
2009) | 13 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/BookmarkBar.xib?r1=25507&r2=25506
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h?r1=25507&r2=25506
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=25507&r2=25506
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm?r1=25507&r2=25506
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/menu_button.h?r1=25507&r2=25506
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/menu_button.mm?r1=25507&r2=25506
(Mac) Display the bookmark bar off-the-side menu on mouse down. Also align
the menu.
(Basically, make it like Safari's button.)
We make the button into a |MenuButton|, attach a fixed menu to it in the
nib, and make the |BookmarkBarController| the delegate for this menu so
that we can update the menu just before it's displayed.
As a side effect, also fixes bug 20813.
BUG=21093,20813
TEST=Make sure the bookmark bar off-the-side button works properly under a
variety of circumstances, making sure the menu is properly aligned, etc.
Review URL: http://codereview.chromium.org/199024
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
