Comment #12 on issue 18367 by [email protected]: Hardcoded colors in omnibox2 unreadable on some system themes http://code.google.com/p/chromium/issues/detail?id=18367
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=25508
------------------------------------------------------------------------
r25508 | [email protected] | 2009-09-04 13:44:39 -0700 (Fri, 04 Sep
2009) | 9 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc?r1=25508&r2=25507
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc?r1=25508&r2=25507
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/toolbar_model.cc?r1=25508&r2=25507
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/toolbar_model.h?r1=25508&r2=25507
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc?r1=25508&r2=25507
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/views/location_bar_view.cc?r1=25508&r2=25507
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/views/location_bar_view.h?r1=25508&r2=25507
Merge 25494 - Use system themes where possible in Omnibox edit and
dropdown; in other cases, provide a pair of colors and use whichever
contrasts more with the relevant background color, to maintain readability.
BUG=92,18367
TEST=Use the omnibox on various nondefault and highcontrast system themes.
Observe that everything is always readable.
Review URL: http://codereview.chromium.org/200009
[email protected]
Review URL: http://codereview.chromium.org/193026
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
