Status: Unconfirmed Owner: ---- Labels: Type-Bug Pri-2 OS-All Area-Misc New issue 21139 by gmangoog: Chromium Code base does not follow Chromium's Coding Style Guidelines http://code.google.com/p/chromium/issues/detail?id=21139
The Chromium Contributing Code page http://dev.chromium.org/developers/contributing-code says code must follow these guidelines http://dev.chromium.org/developers/coding-style Those guidelines discourage multiple-inheritance and give specific rules on how to use it if it must be used http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Multiple_Inheritance And yet the Chromium code base has many places that don't follow these rules. It's hard to contribute to the code base and follow the rules if the rules are broken and therefore there is no way to know which rules are okay to break and which are not. Examples: http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/npobject_proxy.h?view=markup class NPObjectProxy : public IPC::Channel::Listener, public IPC::Message::Sender { http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/npobject_stub.h?view=markup class NPObjectStub : public IPC::Channel::Listener, public IPC::Message::Sender { http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/npobject_proxy.h?view=markup // Encapsulates an IPC channel between a renderer and a plugin process. class PluginChannelBase : public IPC::Channel::Listener, public IPC::Message::Sender, public base::RefCountedThreadSafe<PluginChannelBase> { Change the rules or change the code. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
