Status: Available
Owner: ----
CC: [email protected],  [email protected],  [email protected],   
[email protected]
Labels: Type-Bug Pri-2 OS-All Area-Misc Size-Medium

New issue 21140 by tony.chromium: enable compiler warnings for webkit/glue  
and webkit/appcache
http://code.google.com/p/chromium/issues/detail?id=21140

We currently compile all of webkit.gyp as external code.  That is, we
disable warnings and warnings-as-errors.  I understand why we have this for
WebCore, but it would be nice to enable for our code in webkit.gyp.  The
two obvious targets are glue and appcache.

I tried adding:
      'variables': {
         'chromium_code': 1,
       },
To the targets, but that didn't work, probably because external_code.gypi
already got pulled in when common.gypi got pulled in?

A side project would be to turn on -Wall in WebCore so some day we can
compile with -Werror.

I bring all of this up because I made a change upstream to WebCore that -
Wall would have caught.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to