Comment #1 on issue 21137 by [email protected]: Memory leak in
autocomplete field drawing when focussed.
http://code.google.com/p/chromium/issues/detail?id=21137
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=25567
------------------------------------------------------------------------
r25567 | [email protected] | 2009-09-04 17:56:56 -0700 (Fri, 04 Sep 2009)
| 16 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm?r1=25567&r2=25566
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm?r1=25567&r2=25566
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cocoa_test_helper.h?r1=25567&r2=25566
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cocoa_test_helper.mm
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=25567&r2=25566
M
http://src.chromium.org/viewvc/chrome/trunk/src/tools/valgrind/memcheck/suppressions_mac.txt?r1=25567&r2=25566
[Mac] Add testing code to expose an NSColor memory leak.
AutocompleteTextFieldCell calls -keyboardFocusIndicatorColor when
drawing the focus ring, which valgrind considers a leak. While we
were testing drawing when not focussed, unit tests could not test
drawing when focussed without the window being made key, which is bad
for many reasons.
This change adds some code to allow faking the key window, then adds
tests for drawing when focussed which exposes the memory leak, then
adds a suppression for that memory leak.
http://crbug.com/21137
TEST=valgrind AutocompleteTextFieldCellTest.Display
Review URL: http://codereview.chromium.org/192031
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
