Comment #3 on issue 21659 by [email protected]: CMYK JPEG rendered wrong either on the Mac or on Windows. http://code.google.com/p/chromium/issues/detail?id=21659
I'm sure you've seen this because I know you used this as an example when you added CMYK JPEG support to WebKit... http://bonsai.mozilla.org/cvsblame.cgi? file=mozilla/modules/libpr0n/decoders/jpeg/nsJPEGDecoder.cpp&rev=1.94&mark= 402-404#402 They're taking care to only invert when they see the Adobe marker. WebCore should probably follow suit. libjpeg handles Adobe format detection, so in WebCore, this would be a check on info->saw_Adobe_marker in JPEGImageDecoder::outputScanlines. While we're in there, take a look at http://trac.webkit.org/browser/trunk/WebCore/platform/image- decoders/jpeg/JPEGImageDecoder.cpp?rrev=47876#L470. At line 474, which was added after you added CMYK support, that should be * 4, not 3, right? We should probably move this discussion to a webkit.org bug. It doesn't really affect the bug at hand, because Mac Chromium isn't using any of this code, it's using CG for image decoding. Whether or not we wean our Mac version off of the CG decoders, we should file a bug against Apple for handling inverted CMYK JPEGs in the CG decoder, as they appear not to. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
