Comment #6 on issue 19073 by [email protected]: Implement extension toolstrips for mac http://code.google.com/p/chromium/issues/detail?id=19073
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=26311
------------------------------------------------------------------------
r26311 | [email protected] | 2009-09-15 17:59:04 -0700 (Tue, 15 Sep 2009)
| 16 lines
Changed paths:
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/ExtensionShelf.xib
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.h?r1=26311&r2=26310
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=26311&r2=26310
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extension_shelf_controller.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extension_shelf_controller.mm
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extension_shelf_controller_unittest.mm
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extension_view_mac.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extension_view_mac.mm
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/status_bubble_mac.h?r1=26311&r2=26310
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/status_bubble_mac.mm?r1=26311&r2=26310
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=26311&r2=26310
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=26311&r2=26310
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h?r1=26311&r2=26310
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm?r1=26311&r2=26310
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=26311&r2=26310
Add a bare-bones extension shelf that displays extension items on OS X.
This brings our extension support to about the level it has on linux.
One issue is that the toolstrips are webpages with a background image that
just happens to look like the shelf they are on. But the background images
are not updated on key->nonkey window changes, so the toolstrip backgrounds
look slightly off in one of the two cases. If we decide to keep the shelf,
we should fix this, but see the bug for erikkay's stance on this.
Also, the NTP is only loaded after all toolstrips have been loaded for some
reason. That's what happens on the other platforms too, I believe.
The extension shelf uses the DownloadShelfView as background view for now.
Screenie: http://imgur.com/wSHgU.png
BUG=19073
TEST=Extensions that live in the shelf should show up. They should be
clickable, resize correctly (e.g. the build status extension), and the
shelf should interact in a sane way with the status bubble.
Review URL: http://codereview.chromium.org/175025
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
