Comment #5 on issue 21028 by [email protected]: Info bubble should not use corner images that assume a white background http://code.google.com/p/chromium/issues/detail?id=21028
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=26394
------------------------------------------------------------------------
r26394 | [email protected] | 2009-09-16 14:33:45 -0700 (Wed, 16 Sep
2009) | 7 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_b.png?r1=26394&r2=26393
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_b_arrow.png
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_bl.png?r1=26394&r2=26393
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_br.png?r1=26394&r2=26393
D /trunk/src/chrome/app/theme/bubble_corner_bl.png
D /trunk/src/chrome/app/theme/bubble_corner_br.png
D /trunk/src/chrome/app/theme/bubble_corner_tl.png
D /trunk/src/chrome/app/theme/bubble_corner_tr.png
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_l.png?r1=26394&r2=26393
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_r.png?r1=26394&r2=26393
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_t.png?r1=26394&r2=26393
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_t_arrow.png
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_tl.png?r1=26394&r2=26393
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_tr.png?r1=26394&r2=26393
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=26394&r2=26393
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bubble_positioner.h?r1=26394&r2=26393
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bubble_border.cc?r1=26394&r2=26393
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bubble_border.h?r1=26394&r2=26393
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/info_bubble.cc?r1=26394&r2=26393
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/info_bubble.h?r1=26394&r2=26393
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.cc?r1=26394&r2=26393
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.h?r1=26394&r2=26393
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_star_toggle.cc?r1=26394&r2=26393
Convert InfoBubble to using BubbleBorder. This also replaces the border
graphics with a slightly darker set from Nicholas.
The downside here is that the Linux views code is definitely going to be
broken by this. I'm not sure of the best design for Linux views, so I
haven't implemented one.
BUG=21028
TEST=Open info bubbles (click star button, hover lock icon) and observe
they are rendered with an identical border/shadow to the Omnibox dropdown,
and at the same vertical position.
Review URL: http://codereview.chromium.org/195099
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
