Comment #1 on issue 21574 by [email protected]: Mac chromium crashes  
when audio plays to the end of stream
http://code.google.com/p/chromium/issues/detail?id=21574

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=26510

------------------------------------------------------------------------
r26510 | [email protected] | 2009-09-17 15:28:15 -0700 (Thu, 17 Sep 2009)  
| 21 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/mac/audio_output_mac.cc?r1=26510&r2=26509
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/mac/audio_output_mac.h?r1=26510&r2=26509
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/mac/audio_output_mac_unittest.cc?r1=26510&r2=26509

Fixing audio in mac

TEST=media_unittests
BUG=21574

Several problems in mac audio:
1. AudioQueueEnqueueBuffer doesn't accept empty buffers. But
    we often hit buffer underrun with various reasons. In
    order to simulate the behavior of Windows that empty
    buffer would make the callback be called after a short time,
    we write a short buffer of silence.
2. Mac audio doesn't provide pending bytes (unplayed buffer
    size in audio buffer). This is now fixed by having a
    running counter.
3. After Stop() is called, Start() will take a long time for
    the audio packet to be played. It is found that
    AudioQueueEnqueueBuffer should be called before
    AudioQueueStart otherwise we'll hit this problem of long
    delay for start.

Review URL: http://codereview.chromium.org/194112
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to