Comment #1 on issue 22070 by [email protected]: Toolstrip theme
background not updated when resizing Chrome window
http://code.google.com/p/chromium/issues/detail?id=22070
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=26526
------------------------------------------------------------------------
r26526 | [email protected] | 2009-09-17 17:42:57 -0700 (Thu, 17 Sep 2009)
| 7 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc?r1=26526&r2=26525
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_shelf.cc?r1=26526&r2=26525
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_shelf.h?r1=26526&r2=26525
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_view.cc?r1=26526&r2=26525
While fixing bug 22070 (Toolstrip theme background not updated when
resizing Chrome window) I added code to trigger repainting the background
on resize. This flushed out a problem (Skia exceptions) that was causing
the extension tests to become flaky on the bots (bug 22135). I've changed
the code to do a deep copy on the subset bitmap we get before passing it
down to the renderer, which causes Skia to not go haywire when drawing the
background.
That makes it possible to fix bug 22070, which now causes the background to
be updated on resize. There is also now no need to set the
background_needs_repaint_ flag to true before calling Layout. We also don't
need to keep track of whether we are detached or not, we just need to
monitor the background_needs_repaint_ flag.
BUG=22070, 22135
TEST=Monitor the bots and see if the tests become flaky again.
Review URL: http://codereview.chromium.org/215017
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
