Comment #3 on issue 20810 by [email protected]: Browser crash @
DownloadShelfContextMenu::ExecuteItemCommand()
http://code.google.com/p/chromium/issues/detail?id=20810
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=26536
------------------------------------------------------------------------
r26536 | [email protected] | 2009-09-17 18:01:19 -0700 (Thu, 17 Sep 2009) |
14 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_shelf.cc?r1=26536&r2=26535
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_shelf.h?r1=26536&r2=26535
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/download_item_view.cc?r1=26536&r2=26535
Fix a bug where we access a view after deletion.
When the download shelf menu option 'Remove' is chosen,
the view is removed and deleted (along with the object
representing the download) so we must not access them
after the removal.
This CL NULLs the download pointer in the menu to
prevent any futher access.
BUG=20810
TEST=Remove an item from the download shelf and Chrome
should not crash.
Review URL: http://codereview.chromium.org/216018
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
