Comment #19 on issue 14562 by [email protected]: Support the mac find
pasteboard (cmd-f should write to it, so should cmd-e. cmd-g should search
for what's in there)
http://code.google.com/p/chromium/issues/detail?id=14562
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=27015
------------------------------------------------------------------------
r27015 | [email protected] | 2009-09-23 15:43:00 -0700 (Wed, 23 Sep 2009)
| 13 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.cc?r1=27015&r2=27014
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/find_bar_bridge.mm?r1=27015&r2=27014
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h?r1=27015&r2=27014
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm?r1=27015&r2=27014
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm?r1=27015&r2=27014
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/find_pasteboard.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/find_pasteboard.mm
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/find_pasteboard_unittest.mm
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/find_bar_controller.cc?r1=27015&r2=27014
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_message_filter_mac.mm?r1=27015&r2=27014
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=27015&r2=27014
Let cmd-f/cmd-g use the findboard.
In a nutshell, this means that the find bars honor the global find
pasteboard, which is like a clipboard, but for searches. See the TEST
section below for consequences, and also see the bug for more information.
BUG=14562
TEST=
* Select some text, hit cmd-e, cmd-g. This should search for the marked
text and open the find bar if it's not open.
* Open TextEdit, hit cmd-f. Enter some text, hit enter. Switch back to
Chrome with an open find bar. The find bar should now contain the text you
entered in TextEdit
* Enter different text into chrome's find bar, switch back to TextEdit. Its
find window should now contain the new text.
* Search for something in one tab, switch to another tab. It should contain
the same text in the findbar as the first one.
* Open the findbar, select some text, hit cmd-e. The find bar should be
updated with the selected text and this text should be highlighted in the
web page. Find bars in other tabs should be updated with that text as well.
Review URL: http://codereview.chromium.org/206035
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
