Comment #4 on issue 22864 by [email protected]: Failure parsing valid
PAC script, if it ends with a comment
http://code.google.com/p/chromium/issues/detail?id=22864
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=27057
------------------------------------------------------------------------
r27057 | [email protected] | 2009-09-24 00:19:30 -0700 (Thu, 24 Sep 2009)
| 12 lines
Changed paths:
A
http://src.chromium.org/viewvc/chrome/branches/195/src/net/data/proxy_resolver_v8_unittest/ends_with_comment.js
M
http://src.chromium.org/viewvc/chrome/branches/195/src/net/proxy/proxy_resolver_v8.cc?r1=27057&r2=27056
M
http://src.chromium.org/viewvc/chrome/branches/195/src/net/proxy/proxy_resolver_v8_unittest.cc?r1=27057&r2=27056
Backport r27035 to 195 branch (chrome 3).
Original review: http://codereview.chromium.org/223016
Fix a bug where if a PAC script ended with a comment and no newline, it
would fail to parse.
The library is now compiled and executed in a separate pass, rather than
trying to append the source segments.
BUG=http://crbug.com/22864
TEST=ProxyResolverV8Test.TrailingComment
Review URL: http://codereview.chromium.org/235001
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---