Comment #1 on issue 22954 by [email protected]: main menu should  
support popups and do a keyboard grab
http://code.google.com/p/chromium/issues/detail?id=22954

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=27179

------------------------------------------------------------------------
r27179 | [email protected] | 2009-09-25 06:40:00 -0700 (Fri, 25 Sep 2009) |  
13 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/main_menu.cc?r1=27179&r2=27178
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/main_menu.h?r1=27179&r2=27178
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=27179&r2=27178

Changes the main menu to do the following:
. Creates a TabContents in CreateNewWindow rather than a
   RenderViewHost. We want to support the ability to open popups from
   this menu, so going with TabContents directly seemed the best
   option.
. Showing the menu now does a keyboard grab. This is needed so that
   keyboard events go to the menu and focus doesn't remain whever it
   was when the menu was shown.

BUG=22954
TEST=see bug

Review URL: http://codereview.chromium.org/219037
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to