Comment #1 on issue 23380 by [email protected]: Browser actions: integrate with wrench menu http://code.google.com/p/chromium/issues/detail?id=23380
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=27599
------------------------------------------------------------------------
r27599 | [email protected] | 2009-09-30 00:32:01 -0700 (Wed, 30 Sep 2009) | 8
lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_resource.h?r1=27599&r2=27598
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=27599&r2=27598
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.cc?r1=27599&r2=27598
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.h?r1=27599&r2=27598
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/browser_action_test.cc
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=27599&r2=27598
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=27599&r2=27598
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.cc?r1=27599&r2=27598
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.h?r1=27599&r2=27598
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=27599&r2=27598
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.cc?r1=27599&r2=27598
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.cc?r1=27599&r2=27598
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.h?r1=27599&r2=27598
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_unittest.cc?r1=27599&r2=27598
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/make_page_red
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/make_page_red/background.html
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/make_page_red/icon.png
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/make_page_red/manifest.json
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/make_page_red_no_icon
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/make_page_red_no_icon/background.html
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/make_page_red_no_icon/manifest.json
Integrate browser actions with the wrench menu. Browser
actions always show up in a submenu of the wrench menu, and
if they have an icon, they also show up in the toolbar area.
BUG=23380,22883
TEST=Added new automated tests for the command handling, but we need to
test that the menu items show up manually. To do that, run with no
extension installed, you should see "extensions" in the wrench menu. Add an
extension that adds a browser action, you should now see an "extensions"
submenu with "manage extensions" and the browser action(s) in the submenu.
Review URL: http://codereview.chromium.org/246037
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
