Comment #12 on issue 5638 by [email protected]: Closing a tab should
do fast shutdown (terminate) when possible
http://code.google.com/p/chromium/issues/detail?id=5638
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=27831
------------------------------------------------------------------------
r27831 | [email protected] | 2009-10-01 21:53:59 -0700 (Thu, 01 Oct 2009)
| 14 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=27831&r2=27830
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/renderer_webkitclient_impl.cc?r1=27831&r2=27830
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/renderer_webkitclient_impl.h?r1=27831&r2=27830
Make sudden termination into a counter.
We were incorrectly interpreting enableSuddenTermination to mean "enable
sudden termination". Really it should just decrement a counter, and we
should only enable sudden termination when that counter reaches 0.
Related to, but not the fix for, http://crbug.com/5638
This may have been causing memory corruption due to shutting down the
renderer process while writing to a storage area or icon database (although
honestly I don't actually know if we even use those parts of webkit).
Also, add a ui test that fails before this patch and succeeds with this
patch.
BUG=none
TEST=sudden termination still works on a simple page
Review URL: http://codereview.chromium.org/245036
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
