Comment #4 on issue 23121 by [email protected]: TestOverrideEncoding
test hanging ui_tests
http://code.google.com/p/chromium/issues/detail?id=23121
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=27966
------------------------------------------------------------------------
r27966 | [email protected] | 2009-10-03 18:17:55 -0700 (Sat, 03 Oct 2009) |
14 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.cc?r1=27966&r2=27965
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_encoding_uitest.cc?r1=27966&r2=27965
TestOverrideEncoding hanging is because TabProxy::WaitForNavigation can not
get reply if current last last_navigation_time for tab _tracker is great
than the input last_navigation_time.
See AutomationProvider::WaitForNavigation, it is handled by
IPC_MESSAGE_HANDLER_DELAY_REPLY, which means the message handler need to
send the reply message by itself.
According to current WaitForNavigation logic, if current last
last_navigation_time for tab _tracker is less than the input
last_navigation_time, the replay will be sent by
NavigationNotificationObserver. Otherwise, the reply will never be sent.
So if somehow the test machine is slow, the navigation has happened before
calling AutomationProvider::WaitForNavigation, the caller will never get
reply. That is why TestOverrideEncoding hangs sometimes.
Please refer to http://chrome-svn/viewvc/chrome?view=rev&revision=9585 to
see how the logic was changed before.
The problem also happened on other two places.
BUG=23121
TEST=BrowserEncodingTest.TestOverrideEncoding
Review URL: http://codereview.chromium.org/242024
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
